Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nomad plan does not recognize VAULT_TOKEN #13939

Closed
shoenig opened this issue Aug 1, 2022 · 2 comments · Fixed by #14088
Closed

nomad plan does not recognize VAULT_TOKEN #13939

shoenig opened this issue Aug 1, 2022 · 2 comments · Fixed by #14088
Assignees
@shoenig
Labels
stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/cli type/bug
Milestone
1.3.4

Comments

@shoenig
Copy link
Member

shoenig commented Aug 1, 2022

#13062 (comment)

there is no -vault-token option for nomad plan
@shoenig shoenig mentioned this issue Aug 1, 2022
Closed
@shoenig shoenig added this to the 1.3.x milestone Aug 1, 2022
@michalgm
Copy link

michalgm commented Aug 1, 2022

thanks for opening this - just in case it is not clear, it would be ideal if nomad plan read VAULT_TOKEN from the environment if vault-token is not specified, the same as other commands

@shoenig shoenig self-assigned this Aug 11, 2022
@shoenig shoenig added the stage/accepted Confirmed, and intend to work on. No timeline committment though. label Aug 11, 2022
@shoenig shoenig mentioned this issue Aug 11, 2022
Merged
hc-github-team-nomad-core pushed a commit that referenced this issue Aug 12, 2022
@shoenig
cli: respect vault token in plan command
e96d52d 
This PR fixes a regression where the 'job plan' command would not respect
a Vault token if set via --vault-token or $VAULT_TOKEN.

Basically the same bug/fix as for the validate command in #13062

Fixes #13939
Merged
@mmcquillan mmcquillan modified the milestones: 1.3.x, 1.3.4 Aug 22, 2022
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 21, 2022
jorgemarey pushed a commit to jorgemarey/nomad that referenced this issue Nov 1, 2023
@shoenig @jorgemarey
cli: respect vault token in plan command
d764d59 
This PR fixes a regression where the 'job plan' command would not respect
a Vault token if set via --vault-token or $VAULT_TOKEN.

Basically the same bug/fix as for the validate command in hashicorp#13062

Fixes hashicorp#13939
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@shoenig shoenig

Labels
stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/cli type/bug
Projects
None yet
Milestone
1.3.4
Development

Successfully merging a pull request may close this issue.

cli: support vault token in plan command hashicorp/nomad
3 participants
@shoenig @mmcquillan @michalgm