Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker: configuration for disabling docker healthchecks #14068

Closed
shoenig opened this issue Aug 9, 2022 · 3 comments · Fixed by #14089
Closed

docker: configuration for disabling docker healthchecks #14068

shoenig opened this issue Aug 9, 2022 · 3 comments · Fixed by #14089
Assignees
@shoenig
Labels
stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/driver/docker type/enhancement
Milestone
1.3.4

Comments

@shoenig
Copy link
Member

shoenig commented Aug 9, 2022

When folks want to run a Docker image that has HEALTHCHECK directives baked in the Docker daemon will execute those checks accordingly even though the job-submitter might not want such behavior.

Expand the docker driver plugin configuration to accept something like disable_healthchecks, so that containers are launched with healtchecking disabled.

Prior art kubernetes/kubernetes#50703
@shoenig shoenig added type/enhancement theme/driver/docker stage/accepted Confirmed, and intend to work on. No timeline committment though. labels Aug 9, 2022
@shoenig shoenig modified the milestones: 1.4.0, 1.3.3, 1.3.x Aug 9, 2022
@mikepea
Copy link

mikepea commented Aug 9, 2022 •
edited

This would be great to see included, we've seen this issue trying to run https://hub.docker.com/r/localstack/localstack as a real world example.

@lcarpenter-hashi
Copy link

See also #5310

@shoenig shoenig self-assigned this Aug 11, 2022
@shoenig shoenig mentioned this issue Aug 11, 2022
Merged
hc-github-team-nomad-core pushed a commit that referenced this issue Aug 12, 2022
@shoenig
docker: create a docker task config setting for disable built-in heal…
0bd42a5 
…thcheck

This PR adds a docker driver task configuration setting for turning off
built-in HEALTHCHECK of a container.

References)
https://docs.docker.com/engine/reference/builder/#healthcheck
https://github.com/docker/engine-api/blob/master/types/container/config.go#L16

Closes #5310
Closes #14068
Merged
@lgfa29 lgfa29 modified the milestones: 1.3.x, 1.3.4 Aug 24, 2022
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@shoenig shoenig

Labels
stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/driver/docker type/enhancement
Projects
None yet
Milestone
1.3.4
Development

Successfully merging a pull request may close this issue.

docker: configuration for disable docker healthcheck hashicorp/nomad
4 participants
@mikepea @shoenig @lgfa29 @lcarpenter-hashi