Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: ignore VaultToken when generating job diff #14424

Merged
merged 2 commits into from
Sep 1, 2022
Merged

cli: ignore VaultToken when generating job diff #14424

merged 2 commits into from
Sep 1, 2022

Conversation

lgfa29
Copy link
Contributor

@lgfa29 lgfa29 commented Aug 31, 2022

Backport only to 1.3.x because that's when -vault-token flag was added to the plan command.

From our docs:

This token is cleared from the job after validating and cannot be used within the job executing environment.

So the token shouldn't be considered in the diff as it's not used internally.

Closes #14423

@lgfa29 lgfa29 added the backport/1.3.x backport to 1.3.x release line label Aug 31, 2022
@lgfa29 lgfa29 mentioned this pull request Aug 31, 2022
Closed
shoenig
shoenig approved these changes Sep 1, 2022
View reviewed changes
Copy link
Member

@shoenig shoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lgfa29 lgfa29 merged commit 774101d into main Sep 1, 2022
@lgfa29 lgfa29 deleted the b-ignore-vault-token branch September 1, 2022 14:01
@hc-github-team-nomad-core hc-github-team-nomad-core mentioned this pull request Sep 1, 2022
Merged
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shoenig shoenig shoenig approved these changes

@angrycub angrycub Awaiting requested review from angrycub

Assignees
No one assigned
Labels
backport/1.3.x backport to 1.3.x release line
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nomad job plan leaks VAULT_TOKEN in output
2 participants
@lgfa29 @shoenig