Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of cli: ignore VaultToken when generating job diff into release/1.3.x #14435

Conversation

hc-github-team-nomad-core
Copy link
Contributor

Backport

This PR is auto-generated from #14424 to be assessed for backporting due to the inclusion of the label backport/1.3.x.

The below text is copied from the body of the original PR.


Backport only to 1.3.x because that's when -vault-token flag was added to the plan command.

From our docs:

This token is cleared from the job after validating and cannot be used within the job executing environment.

So the token shouldn't be considered in the diff as it's not used internally.

Closes #14423

@hc-github-team-nomad-core hc-github-team-nomad-core force-pushed the backport/b-ignore-vault-token/recently-flexible-stud branch from f9d290b to 49f6f2e Compare September 1, 2022 14:02
@hc-github-team-nomad-core hc-github-team-nomad-core merged commit fa34b15 into release/1.3.x Sep 1, 2022
@hc-github-team-nomad-core hc-github-team-nomad-core deleted the backport/b-ignore-vault-token/recently-flexible-stud branch September 1, 2022 14:02
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants