Added task links to various alloc tables #14592
Conversation
Ember Asset Size actionAs of b1eac60 Files that got Bigger 🚨:
Files that stayed the same size 🤷:
|
Ember Test Audit comparison
|
| {{!-- TODO: in-page logs --}} | ||
| {{!-- <FlightIcon @name="logs" /> --}} |
There was a problem hiding this comment.
(very temporary) placeholder: covered in #14579
| @@ -0,0 +1,76 @@ | |||
| import Ember from 'ember'; | |||
There was a problem hiding this comment.
All of this is largely ported from task-row, but updated to a glimmer component.
| &.with-collapsed-borders { | ||
| border-collapse: collapse; | ||
| } |
There was a problem hiding this comment.
Has the effect, with task-sub-rows having a white upper border, of having a same-container layout.
| @@ -174,7 +174,7 @@ | |||
| ] | |||
| }, | |||
| "dependencies": { | |||
| "@hashicorp/ember-flight-icons": "^2.0.5", | |||
| "@hashicorp/ember-flight-icons": "^2.0.12", | |||
There was a problem hiding this comment.
Updated to include logs icon
| {{!-- TODO: in-page logs --}} | ||
| {{!-- <FlightIcon @name="logs" /> --}} |
There was a problem hiding this comment.
nit: Did you mean to commit this?
There was a problem hiding this comment.
Yes, commented here: #14592 (review)
| constructor() { | ||
| super(...arguments); | ||
| // Kick off stats polling | ||
| const allocation = this.task.allocation; | ||
| if (allocation) { | ||
| this.fetchStats.perform(); | ||
| } else { | ||
| this.fetchStats.cancelAll(); | ||
| } | ||
| } |
There was a problem hiding this comment.
question will this stop polling when the component unmounts?
There was a problem hiding this comment.
Yep; inherited from our other stats fetchers, like task-row. On unmount, or even on hide, this will stop its stats polling.
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Resolves #14578
Adds a quicker way to dive a level or two deeper into Nomad via the UI, by optionally listing tasks beneath their parent allocations in four places:
In all cases, toggling sets a localStorage property for future usage.