[ui] task logs in sidebar #14612
[ui] task logs in sidebar #14612
Conversation
Ember Asset Size actionAs of 74ff4e6 Files that got Bigger 🚨:
Files that stayed the same size 🤷:
|
Ember Test Audit comparison
|
| @@ -10,7 +10,7 @@ export default class AllocationServiceSidebarComponent extends Component { | |||
| } | |||
| keyCommands = [ | |||
| { | |||
| label: 'Close Evaluations Sidebar', | |||
| label: 'Close Service Sidebar', | |||
There was a problem hiding this comment.
Side-effect; adding correct name.
| if (this.shouldFillHeight) { | ||
| this.fillAvailableHeight(); | ||
| } |
There was a problem hiding this comment.
conditionalizing fillAvailableHeight(), as it tries to fill window.height, which is greater than our sidebar wants. Handled in CSS elsewhere for our sidebar logs element.
| vertical-align: baseline; | ||
| position: relative; | ||
| top: 1px; |
There was a problem hiding this comment.
This affects (positively) a few others instances where we use our element and it was slightly misaligned.
| @@ -19,7 +19,7 @@ | |||
| "job-page/parts/latest-deployment" job=@job handleError=this.handleError | |||
| ) | |||
| TaskGroups=(component "job-page/parts/task-groups" job=@job) | |||
| RecentAllocations=(component "job-page/parts/recent-allocations" job=@job) | |||
| RecentAllocations=(component "job-page/parts/recent-allocations" job=@job activeTask=@activeTask setActiveTaskQueryParam=@setActiveTaskQueryParam) | |||
There was a problem hiding this comment.
This, and further job-page/*.hbs file changes, were tricky to figure out how to best handle (and thank you to @DingoEatingFuzz for unblocking me!)
The nature of our higher-order components is such that, to get query parameters at the /job level, we have to declare our passed variables more verbosely than desired.
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Resolves #14579
Adds the ability to view logs for a given task from a parent context:
In other words: from within any context that we display an allocations table.
This adds a portalTarget to the application level to reduce overhead, and hoists the sidebar from the recently-added
<TaskSubRow />component.The logs feed is using the same component and layout that its dedicated page uses.
TODO