Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nsd: add implicit Nomad version constraint for tasks which include checks #14862

Closed
jrasell opened this issue Oct 10, 2022 · 1 comment · Fixed by #14868
Closed

nsd: add implicit Nomad version constraint for tasks which include checks #14862

jrasell opened this issue Oct 10, 2022 · 1 comment · Fixed by #14868
Assignees
@shoenig
Labels
stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/core theme/service-discovery/nomad type/enhancement
Projects
Nomad - Community Issues Triage

Comments

@jrasell
Copy link
Member

jrasell commented Oct 10, 2022

In clusters running mixed versions of clients at 1.3.x and 1.4.x, allocations that include Nomad service discovery health checks could be placed on clients that do not include the functionality due to their version. It may therefore be useful to add an implicit constraint on tasks which utilise Nomad service discovery checks to ensure they get placed on clients running Nomad version 1.4.0 or greater.
@jrasell jrasell added type/enhancement theme/core stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/service-discovery/nomad labels Oct 10, 2022
@jrasell jrasell added this to Needs Triage in Nomad - Community Issues Triage via automation Oct 10, 2022
@jrasell jrasell moved this from Needs Triage to Needs Roadmapping in Nomad - Community Issues Triage Oct 10, 2022
@shoenig shoenig self-assigned this Oct 10, 2022
shoenig added a commit that referenced this issue Oct 10, 2022
@shoenig
[no ci] servicedisco: implicit constraint for nomad v1.4 when using n…
7525456 
…sd checks

This PR adds a jobspec mutator to constrain jobs making use of checks
in the nomad service provider to nomad clients of at least v1.4.0.

Before, in a mixed client version cluster it was possible to submit
an NSD job making use of checks and for that job to land on an older,
incompatible client node.

Closes #14862
@shoenig shoenig mentioned this issue Oct 10, 2022
Merged
shoenig added a commit that referenced this issue Oct 10, 2022
@shoenig
servicedisco: implicit constraint for nomad v1.4 when using nsd checks
79901fa 
This PR adds a jobspec mutator to constrain jobs making use of checks
in the nomad service provider to nomad clients of at least v1.4.0.

Before, in a mixed client version cluster it was possible to submit
an NSD job making use of checks and for that job to land on an older,
incompatible client node.

Closes #14862
shoenig added a commit that referenced this issue Oct 10, 2022
@shoenig
servicedisco: implicit constraint for nomad v1.4 when using nsd checks
a856698 
This PR adds a jobspec mutator to constrain jobs making use of checks
in the nomad service provider to nomad clients of at least v1.4.0.

Before, in a mixed client version cluster it was possible to submit
an NSD job making use of checks and for that job to land on an older,
incompatible client node.

Closes #14862
Nomad - Community Issues Triage automation moved this from Needs Roadmapping to Done Oct 11, 2022
Merged
@github-actions
Copy link

github-actions bot commented Feb 9, 2023

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@shoenig shoenig

Labels
stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/core theme/service-discovery/nomad type/enhancement
Projects
Nomad - Community Issues Triage
Archived in project
Nomad - Community Issues Triage
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

servicedisco: implicit constraint for nomad v1.4 when using nsd checks hashicorp/nomad
2 participants
@shoenig @jrasell