keyring: remove root key GC #15034
Merged
keyring: remove root key GC #15034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgross
force-pushed
the
b-disable-root-key-gc
branch
from
96850fb
to
04c53bc
Compare
tgross
commented
Oct 25, 2022
| @@ -200,15 +200,11 @@ server { | |||
| rejoin the cluster. | |||
|
|
|||
| - `root_key_gc_interval` `(string: "10m")` - Specifies the interval between | |||
There was a problem hiding this comment.
Note: I'm intentionally leaving the name here because we'll want to use this interval for GC once we circle back to it, and I don't want to have to add a new interval for that too. Same applies to the name of the core job emitted by the leader.
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to repro #14981 I discovered that the approach we're using to GC keys by timeboxing them based on allocation
CreateIndexsimply won't work. Allocations would need to have a reference to the key ID that signed their WI. The current check we have is based on allocation index but it's bugged: we can only GC inactive keys newer than the newest allocation, which is useless.We only rotate keys every 30d by default, so remove the key GC for now until we can come up with a better long-term fix for this problem.