Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: batchFirstFingerprints does not update device on node after v1.3.5 #15125

Merged
merged 2 commits into from
Nov 3, 2022

Conversation

vuuihc
Copy link
Contributor

@vuuihc vuuihc commented Nov 3, 2022

Fixes #14888

Hi, thanks for this awesome project. Recently when I use nomad with the plugin nomad-device-nvidia, I found that the plugin did not work well, then I found this issue reporting the same problem. By researching the code, I found that the Devices was not successfully updated in batchFirstFingerprints, maybe I try help fix it by this PR.

@hashicorp-cla
Copy link

hashicorp-cla commented Nov 3, 2022

CLA assistant check
All committers have signed the CLA.

@shoenig
Copy link
Member

shoenig commented Nov 3, 2022

Spot checking on an ec2 instance

ubuntu@ip-172-31-23-245:~$ ./nomad-pr version 
Nomad v1.4.3-dev (52d0dcbed281498dc8b64b60009a10c500dcd348)
ubuntu@ip-172-31-23-245:~$ ./nomad-pr node status -self -verbose | grep -C 2 NVIDIA

Device Resource Utilization
nvidia/gpu/NVIDIA A10G[GPU-7a3f1fe2-a6fb-12e4-6e32-632f070a98d4]  296 / 23028 MiB

Allocations
--

Device Group Attributes
Device Group     = nvidia/gpu/NVIDIA A10G
bar1             = 32768 MiB
cores_clock      = 1710 MHz

@github-actions
Copy link

github-actions bot commented Mar 4, 2023

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/1.2.x backport to 1.1.x release line backport/1.3.x backport to 1.3.x release line backport/1.4.x backport to 1.4.x release line
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Nvidia GPU Device Plugin" not working
3 participants