Backport of fix: batchFirstFingerprints does not update device on node after v1.3.5 into release/1.3.x #15132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-nomad-core
force-pushed
the
backport/fix/batch_first_footprint/mildly-allowed-liger
branch
from
aafb4ed
to
35ed127
Compare
hc-github-team-nomad-core
deleted the
backport/fix/batch_first_footprint/mildly-allowed-liger
branch
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #15125 to be assessed for backporting due to the inclusion of the label backport/1.3.x.
The below text is copied from the body of the original PR.
Fixes #14888
Hi, thanks for this awesome project. Recently when I use nomad with the plugin
nomad-device-nvidia, I found that the plugin did not work well, then I found this issue reporting the same problem. By researching the code, I found that the Devices was not successfully updated in batchFirstFingerprints, maybe I try help fix it by this PR.