Fix goroutine leakage #15180
Merged
Fix goroutine leakage #15180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hi @stswidwinski, nice find and thanks for the fix! Any chance you can sign the CLA? We can't merge anything without that |
|
I'm working on that. Sorry, please give me a few more days to figure it out.
…On Thu, Nov 10, 2022, 10:21 AM Seth Hoenig ***@***.***> wrote:
Hi @stswidwinski <https://github.com/stswidwinski>, nice find and thanks
for the fix! Any chance you can sign the CLA? We can't merge anything
without that
—
Reply to this email directly, view it on GitHub
<#15180 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AECDANANIHWO6M4WJT4JFEDWHUHGTANCNFSM6AAAAAARZUWZQI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@shoenig the CLA has been signed. |
shoenig
added
backport/1.2.x
This was referenced Nov 17, 2022
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see #15179 for a more detailed explanation. The call to
joincontext.Joingenerates agoroutinewhich must be garbage collected (which means the context cleanup).