Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ui] Add namespaces to exec window #15454

Merged
merged 1 commit into from
Dec 2, 2022
Merged

[ui] Add namespaces to exec window #15454

merged 1 commit into from
Dec 2, 2022

Conversation

philrenaud
Copy link
Contributor

Fixes an issue where namespaces weren't being respected in Exec window URLs upon refresh (they were on initial load, by virtue of having the full job object passed in via openExecUrl).

image
image

Resolves #13921

@philrenaud philrenaud self-assigned this Dec 2, 2022
@philrenaud philrenaud linked an issue Dec 2, 2022 that may be closed by this pull request
[ui] job exec window refresh for jobs in non-default namespaces #13921
Closed
@philrenaud philrenaud added the backport/1.4.x backport to 1.4.x release line label Dec 2, 2022
@philrenaud philrenaud force-pushed the 13921-ui-job-exec-window-refresh-for-jobs-in-non-default-namespaces branch from fc167ed to 1ec95ed Compare December 2, 2022 16:06
@github-actions
Copy link

github-actions bot commented Dec 2, 2022 •
edited
Loading

Ember Asset Size action

As of 502e5b0

Files that got Bigger 🚨:

File raw gzip
nomad-ui.js +12 B +2 B

Files that stayed the same size 🤷‍:

File raw gzip
vendor.js 0 B 0 B
nomad-ui.css 0 B 0 B
vendor.css 0 B 0 B

@github-actions
Copy link

github-actions bot commented Dec 2, 2022 •
edited
Loading

Ember Test Audit comparison

main 502e5b0 change
passes 1435 1435 0
failures 0 1 +1
flaky 0 0 0
duration 10m 45s 042ms 000ms -10m 45s 042ms

ChaiWithJai
ChaiWithJai approved these changes Dec 2, 2022
View reviewed changes
Copy link
Contributor

@ChaiWithJai ChaiWithJai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ui/app/controllers/exec.js Outdated Show resolved Hide resolved
@philrenaud philrenaud force-pushed the 13921-ui-job-exec-window-refresh-for-jobs-in-non-default-namespaces branch from 1ec95ed to 502e5b0 Compare December 2, 2022 20:04
@philrenaud philrenaud merged commit 2d4611a into main Dec 2, 2022
@philrenaud philrenaud deleted the 13921-ui-job-exec-window-refresh-for-jobs-in-non-default-namespaces branch December 2, 2022 20:38
@hc-github-team-nomad-core hc-github-team-nomad-core mentioned this pull request Dec 2, 2022
Merged
@github-actions
Copy link

github-actions bot commented Apr 2, 2023

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ChaiWithJai ChaiWithJai ChaiWithJai approved these changes

Assignees

@philrenaud philrenaud

Labels
backport/1.4.x backport to 1.4.x release line
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ui] job exec window refresh for jobs in non-default namespaces
2 participants
@philrenaud @ChaiWithJai