Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of [ui] Add namespaces to exec window into release/1.4.x #15456

Conversation

hc-github-team-nomad-core
Copy link
Contributor

Backport

This PR is auto-generated from #15454 to be assessed for backporting due to the inclusion of the label backport/1.4.x.

The below text is copied from the body of the original PR.


Fixes an issue where namespaces weren't being respected in Exec window URLs upon refresh (they were on initial load, by virtue of having the full job object passed in via openExecUrl).

image
image

Resolves #13921

@hc-github-team-nomad-core hc-github-team-nomad-core force-pushed the backport/13921-ui-job-exec-window-refresh-for-jobs-in-non-default-namespaces/happily-teaching-cattle branch from 690a010 to 810a100 Compare December 2, 2022 20:38
@hc-github-team-nomad-core hc-github-team-nomad-core merged commit 3dfbb07 into release/1.4.x Dec 2, 2022
@hc-github-team-nomad-core hc-github-team-nomad-core deleted the backport/13921-ui-job-exec-window-refresh-for-jobs-in-non-default-namespaces/happily-teaching-cattle branch December 2, 2022 20:38
@github-actions
Copy link

github-actions bot commented Dec 2, 2022

Ember Test Audit comparison

release/1.4.x 810a100 change
passes 1422 1422 0
failures 0 0 0
flaky 0 0 0
duration 12m 40s 622ms 10m 06s 029ms -2m 34s 593ms

@github-actions
Copy link

github-actions bot commented Apr 2, 2023

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants