Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler: allow using device ID as attribute #15455

Merged
merged 2 commits into from
Jan 10, 2023
Merged

scheduler: allow using device ID as attribute #15455

merged 2 commits into from
Jan 10, 2023

Conversation

lgfa29
Copy link
Contributor

@lgfa29 lgfa29 commented Dec 2, 2022

Devices are fingerprinted as groups of similar devices. This prevented specifying specific device by their ID in constraint and affinity rules.

This commit introduces the ${device.ids} attribute that returns a comma separated list of IDs that are part of the device group. Users can then use the set operators to write rules.

Closes hashicorp/nomad-device-nvidia#11

Devices are fingerprinted as groups of similar devices. This prevented
specifying specific device by their ID in constraint and affinity rules.

This commit introduces the `${device.ids}` attribute that returns a
comma separated list of IDs that are part of the device group. Users can
then use the set operators to write rules.
@lgfa29 lgfa29 added the backport/1.4.x backport to 1.4.x release line label Dec 2, 2022
Copy link
Member

@shoenig shoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lgfa29 lgfa29 merged commit 1318477 into main Jan 10, 2023
@lgfa29 lgfa29 deleted the f-device-id branch January 10, 2023 19:28
philrenaud pushed a commit that referenced this pull request Jan 23, 2023
Devices are fingerprinted as groups of similar devices. This prevented
specifying specific device by their ID in constraint and affinity rules.

This commit introduces the `${device.ids}` attribute that returns a
comma separated list of IDs that are part of the device group. Users can
then use the set operators to write rules.
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/1.4.x backport to 1.4.x release line
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add gpu uuid to the fingerprinted attributes
2 participants