fix: Make agent syslog log level inherit from Nomad agent log #15625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
tgross
requested changes
Jan 3, 2023
There was a problem hiding this comment.
This looks great @dttung2905! I agree that it makes the best sense to have the syslog logger inherit the log level from the agent. I've left a suggestion for how to treat the "OFF" level, but I think what you've done for "TRACE" is fine.
Thanks for the PR!
tgross
added
theme/config
theme/logging
backport/1.2.x
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tgross
requested changes
Jan 4, 2023
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
This was referenced Jan 4, 2023
Merged
Merged
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue : #15087
Hi Nomad Core Dev team,
Below is my attempt to fix the issue mentioned above. Imo, we can either make an extra argument for syslog log level or make it inherit from Nomad Agent existing one. This PR is using the latter approach because there is not need to use the former for a rarely used feature.
Would appreciate getting your feedback on this PR, especially on a few issues:
OFFandTRACEin Nomad log_level maps to gsyslog log levelui.ErrorWriterorui.OutputWriter. Please let me know if a unit test is needed or there are better ways to structure the unit test