Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of fix: Make agent syslog log level inherit from Nomad agent log into release/1.4.x #15689

Conversation

hc-github-team-nomad-core
Copy link
Contributor

Backport

This PR is auto-generated from #15625 to be assessed for backporting due to the inclusion of the label backport/1.4.x.

The below text is copied from the body of the original PR.


Fix issue : #15087

Hi Nomad Core Dev team,

Below is my attempt to fix the issue mentioned above. Imo, we can either make an extra argument for syslog log level or make it inherit from Nomad Agent existing one. This PR is using the latter approach because there is not need to use the former for a rarely used feature.

Would appreciate getting your feedback on this PR, especially on a few issues:

  • On the mapping between gsyslog and Nomad Agent log, I'm not entirely sure about how OFF and TRACE in Nomad log_level maps to gsyslog log level
  • I attempted to write one similar to TestCommand_Args() but the log is not captured by either ui.ErrorWriter or ui.OutputWriter. Please let me know if a unit test is needed or there are better ways to structure the unit test

@hc-github-team-nomad-core hc-github-team-nomad-core force-pushed the backport/agent-syslog-log-level/quietly-loved-raven branch from 72d7627 to d5c8e8d Compare January 4, 2023 14:38
@hc-github-team-nomad-core hc-github-team-nomad-core merged commit 205c766 into release/1.4.x Jan 4, 2023
@hc-github-team-nomad-core hc-github-team-nomad-core deleted the backport/agent-syslog-log-level/quietly-loved-raven branch January 4, 2023 14:38
@github-actions
Copy link

github-actions bot commented May 5, 2023

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants