Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consul: restore consul token when reverting a job #15996

Merged
merged 3 commits into from
Feb 1, 2023
Merged

Conversation

shoenig
Copy link
Member

@shoenig shoenig commented Jan 31, 2023

  • consul: restore consul token on job during registration of a reversion
  • e2e: add test for reverting a job with a consul service

Fixes #15964

@shoenig shoenig changed the title consul: reset consul token when reverting a job consul: restore consul token when reverting a job Jan 31, 2023
// Use Vault Token from revert request to perform registration of reverted job.
revJob.VaultToken = args.VaultToken
revJob.VaultToken = args.VaultToken // use vault token from revert to perform (re)registration
revJob.ConsulToken = args.ConsulToken // use consul token from revert to perform (re)registration
Copy link
Member Author

@shoenig shoenig Jan 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[adding] this line is the fix

.changelog/15996.txt Outdated Show resolved Hide resolved
@shoenig shoenig added backport/1.2.x backport to 1.1.x release line backport/1.3.x backport to 1.3.x release line backport/1.4.x backport to 1.4.x release line labels Jan 31, 2023
@shoenig shoenig added this to the 1.4.x milestone Jan 31, 2023
@shoenig shoenig marked this pull request as ready for review February 1, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.2.x backport to 1.1.x release line backport/1.3.x backport to 1.3.x release line backport/1.4.x backport to 1.4.x release line
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to revert job to older version
2 participants