-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nomad panic during RPM post install script execution. #16179
Comments
Hi @apollo13! Can you clarify for me which version of Nomad you're pulling down and whether the RPM you're installing is the official one for that version? |
I am on fedora 37 and pulling the rpm via the official repo:
the rpm in question is
|
is almost the fix we need - but we use the helper function right above that one! I'll open a PR with upstream. |
Lovely thanks! |
In a sidebar discussion we noticed that the panic fix linked above is for a different panic in the same file in runc. The panic you're hitting here is a different one that should probably have been fixed in that PR but is still present on runc's |
This PR wraps the cgroups.IsCgroup2UnifiedMode() helper method from runc in a defer/recover block because it might panic in some cases. Upstream fix in: opencontainers/runc#3745 Closes #16179
This PR wraps the cgroups.IsCgroup2UnifiedMode() helper method from runc in a defer/recover block because it might panic in some cases. Upstream fix in: opencontainers/runc#3745 Closes #16179
This PR wraps the cgroups.IsCgroup2UnifiedMode() helper method from runc in a defer/recover block because it might panic in some cases. Upstream fix in: opencontainers/runc#3745 Closes #16179
This PR wraps the cgroups.IsCgroup2UnifiedMode() helper method from runc in a defer/recover block because it might panic in some cases. Upstream fix in: opencontainers/runc#3745 Closes #16179
I am adding nomad to a fedora coreos system of mine during the build process. I am not exactly sure in which kind of chroot or whatever an rpm-ostree build runs. Nevertheless the postinstall script of the nomad RPM fails like this:
I assume this is because the nomad postinstall script executes the following:
and
nomad version
might already panic? I think it would be nice ifnomad version
would run without to many checks and if that is not possible then maybe at least fix the postinstall script to hide errors?The text was updated successfully, but these errors were encountered: