Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NOMAD_ADDR_* variables incorrect with ipv6 #16550

Closed
valodzka opened this issue Mar 18, 2023 · 3 comments · Fixed by #16723
Closed

NOMAD_ADDR_* variables incorrect with ipv6 #16550

valodzka opened this issue Mar 18, 2023 · 3 comments · Fixed by #16723
Labels
stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/service-discovery type/bug

Comments

@valodzka
Copy link
Contributor

valodzka commented Mar 18, 2023 •
edited
Loading

Env

nomad 1.5.1, linux node with only ipv6 address

Issue

Nomad env vars have invalid format:

NOMAD_HOST_ADDR_http=2a01:4f8:111:1ae1::2:25013
NOMAD_ADDR_http=2a01:4f8:111:1ae1::2:25013

Expected Result

They should be like this:

NOMAD_HOST_ADDR_http=[2a01:4f8:111:1ae1::2]:25013
NOMAD_ADDR_http=[2a01:4f8:111:1ae1::2]:25013

Related issues

No address for services with IPv6 address in UI:
image
@jrasell
Copy link
Member

jrasell commented Mar 20, 2023

Hi @valodzka and thanks for raising this issue. This seems like something we should get fixed up both in the frontend and backend.

@jrasell jrasell added stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/service-discovery labels Mar 20, 2023
@protochron protochron mentioned this issue Mar 21, 2023
Closed
@lgfa29 lgfa29 mentioned this issue Apr 18, 2023
Merged
valodzka added a commit to valodzka/nomad that referenced this issue Apr 20, 2023
@valodzka
fix host port handling for ipv6, fixes hashicorp#16550
4f29f94
@lgfa29
Copy link
Contributor

lgfa29 commented Apr 21, 2023

I believe the UI problem described has the same root cause as #14654. Refreshing the page should display the service address.

Merged
hc-github-team-nomad-core added a commit that referenced this issue Apr 21, 2023
@hc-github-team-nomad-core
Backport of fix host port handling for ipv6, fixes #16550 into releas…
b1a67eb 
…e/1.3.x (#16955)

This pull request was automerged via backport-assistant
Merged
hc-github-team-nomad-core added a commit that referenced this issue Apr 21, 2023
@hc-github-team-nomad-core
Backport of fix host port handling for ipv6, fixes #16550 into releas…
cf0023d 
…e/1.4.x (#16956)

This pull request was automerged via backport-assistant
Merged
hc-github-team-nomad-core added a commit that referenced this issue Apr 21, 2023
@hc-github-team-nomad-core
Backport of fix host port handling for ipv6, fixes #16550 into releas…
213bc9e 
…e/1.5.x (#16957)

This pull request was automerged via backport-assistant
@shoenig shoenig mentioned this issue May 16, 2023
Closed
@github-actions GitHub Actions
Copy link

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/service-discovery type/bug
Projects
Nomad - Community Issues Triage
Archived in project
Milestone
No milestone
3 participants
@valodzka @lgfa29 @jrasell