Updating service tags appends instead of replaces in consul

[schmichael]

When updating tags from ["foo", "bar"] to ["foo", "x"], x will be appended and bar won't be removed in consul. So the result is ["foo", "bar", "x"] instead of ["foo", "x"]

Nomad version

0.4 - master (152c11d)

Operating system and Environment details

Issue

Original submisison:

Hi, I'm using Nomad 0.4 to run some jobs. Is it expected that when you update a service (Consul) tag, the old tag is not removed but instead appended to the service?

Reproduction steps

1. Start consul + nomad
2. run example.nomad
3. Change cache tag to cache2 tag
4. run example.nomad
5. Observe tags in consul include both cache and cache2

[kyhavlov]

It looks like this was broken as a result of the consul syncer tests here being skipped: https://github.com/hashicorp/nomad/blob/master/command/agent/consul/syncer_test.go#L133-L183

[diptanu]

@kaskavalci Yeah we are aware of the commented tests. We are working towards fixing them.

[schmichael]

@kyhavlov Fix should be merged in #1668 and will be included in our next release. Let me know if you continue having problems once that's out.

[kyhavlov]

Any plans to cut a 0.4.2? Or will 0.5 be out relatively soon?

[schmichael]

@kyhavlov 0.5 should be out in a few weeks. HashiConf is next week and more news about 0.5 will be coming out then.

[github-actions]

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.