-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating service tags appends instead of replaces in consul #1661
Comments
It looks like this was broken as a result of the consul syncer tests here being skipped: https://github.com/hashicorp/nomad/blob/master/command/agent/consul/syncer_test.go#L133-L183 |
@kaskavalci Yeah we are aware of the commented tests. We are working towards fixing them. |
Any plans to cut a 0.4.2? Or will 0.5 be out relatively soon? |
@kyhavlov 0.5 should be out in a few weeks. HashiConf is next week and more news about 0.5 will be coming out then. |
I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues. |
When updating tags from
["foo", "bar"]
to["foo", "x"]
,x
will be appended andbar
won't be removed in consul. So the result is["foo", "bar", "x"]
instead of["foo", "x"]
Nomad version
0.4 - master (152c11d)
Operating system and Environment details
Issue
Original submisison:
Reproduction steps
cache
tag tocache2
tagcache
andcache2
The text was updated successfully, but these errors were encountered: