fix host port handling for ipv6, fixes #16550 #16723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
lgfa29
suggested changes
Apr 18, 2023
There was a problem hiding this comment.
Thanks for the PR @valodzka!
Do you think you would be able to add some tests? I think something like TestEnvironment_AsList but using IPv6 addresses would do the trick.
Feel free to reach out if you need any help 🙂
command/agent/agent_endpoint_test.go
Outdated
| @@ -155,7 +155,7 @@ func TestHTTP_AgentJoin(t *testing.T) { | |||
| httpTest(t, nil, func(s *TestAgent) { | |||
| // Determine the join address | |||
| member := s.Agent.Server().LocalMember() | |||
| addr := fmt.Sprintf("%s:%d", member.Addr, member.Port) | |||
| addr := net.JoinHostPort("%s:%d", member.Addr, member.Port) | |||
There was a problem hiding this comment.
Suggested change
| addr := net.JoinHostPort("%s:%d", member.Addr, member.Port) | |
| addr := net.JoinHostPort(member.Addr, member.Port) |
@lgfa29 I'm not very familiar with go but here is my try :) |
lgfa29
added
backport/1.3.x
This was referenced Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16550