services: un-mark group services as deregistered if restart hook runs #16905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR may fix a bug where group services will never be deregistered if the group undergoes a task restart.
shoenig
force-pushed
the
group-service-deregister
branch
from
4ff4036
to
af11145
Compare
tgross
approved these changes
Apr 24, 2023
e2e/consul/alloc_restart_test.go
Outdated
| must.NoError(t, err) | ||
|
|
||
| // make sure our service is no longer registered | ||
| services, _, err = cc.Service("alloc-restart-http", "", nil) |
There was a problem hiding this comment.
I'm pretty sure by the time the alloc is marked running the service will be registered. But service deregistration isn't synchronous with the Job.Deregister RPC, right? I think we need to must.Wait for this API call.
There was a problem hiding this comment.
Good catch, will add that
shoenig
added
backport/1.3.x
shoenig
added a commit
that referenced
this pull request
Apr 24, 2023
…#16905) * services: un-mark group services as deregistered if restart hook runs This PR may fix a bug where group services will never be deregistered if the group undergoes a task restart. * e2e: add test case for restart and deregister group service * cl: add cl * e2e: add wait for service list call
shoenig
added a commit
that referenced
this pull request
Apr 24, 2023
…#16905) * services: un-mark group services as deregistered if restart hook runs This PR may fix a bug where group services will never be deregistered if the group undergoes a task restart. * e2e: add test case for restart and deregister group service * cl: add cl * e2e: add wait for service list call
shoenig
added a commit
that referenced
this pull request
Apr 24, 2023
…#16905) (#16975) * services: un-mark group services as deregistered if restart hook runs This PR may fix a bug where group services will never be deregistered if the group undergoes a task restart. * e2e: add test case for restart and deregister group service * cl: add cl * e2e: add wait for service list call Co-authored-by: Seth Hoenig <shoenig@duck.com>
shoenig
added a commit
that referenced
this pull request
Apr 24, 2023
…#16905) (#16976) * services: un-mark group services as deregistered if restart hook runs This PR may fix a bug where group services will never be deregistered if the group undergoes a task restart. * e2e: add test case for restart and deregister group service * cl: add cl * e2e: add wait for service list call Co-authored-by: Seth Hoenig <shoenig@duck.com>
shoenig
added a commit
that referenced
this pull request
May 16, 2023
…#16905) * services: un-mark group services as deregistered if restart hook runs This PR may fix a bug where group services will never be deregistered if the group undergoes a task restart. * e2e: add test case for restart and deregister group service * cl: add cl * e2e: add wait for service list call
This was referenced May 16, 2023
shoenig
added a commit
that referenced
this pull request
May 16, 2023
…#16905) (#17212) * services: un-mark group services as deregistered if restart hook runs This PR may fix a bug where group services will never be deregistered if the group undergoes a task restart. * e2e: add test case for restart and deregister group service * cl: add cl * e2e: add wait for service list call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR may fix a bug where group services will never be deregistered if the group undergoes an alloc restart.
Fixes #16616
Adds an e2e test case covering the repro in ^