Backport of services: un-mark group services as deregistered if restart hook runs into release/1.4.x #16976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-nomad-core
requested review from
sarahethompson and
jeanneryan
and removed request for
a team
hc-github-team-nomad-core
force-pushed
the
backport/group-service-deregister/distinctly-vast-shiner
branch
from
4bd48e0
to
df74f60
Compare
|
|
…#16905) * services: un-mark group services as deregistered if restart hook runs This PR may fix a bug where group services will never be deregistered if the group undergoes a task restart. * e2e: add test case for restart and deregister group service * cl: add cl * e2e: add wait for service list call
shoenig
force-pushed
the
backport/group-service-deregister/distinctly-vast-shiner
branch
from
df74f60
to
c59d001
Compare
shoenig
deleted the
backport/group-service-deregister/distinctly-vast-shiner
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #16905 to be assessed for backporting due to the inclusion of the label backport/1.4.x.
The below text is copied from the body of the original PR.
This PR may fix a bug where group services will never be deregistered if the group undergoes an alloc restart.
Fixes #16616
Adds an e2e test case covering the repro in ^