Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connect: NOMAD_envoy_version only set if task driver is docker #17040

Closed
shoenig opened this issue May 1, 2023 · 2 comments
Closed

connect: NOMAD_envoy_version only set if task driver is docker #17040

shoenig opened this issue May 1, 2023 · 2 comments
Labels
theme/consul/connect Consul Connect integration type/bug

Comments

@shoenig
Copy link
Contributor

shoenig commented May 1, 2023

In the envoy_bootstrap_hook we have logic that prevents making the query to Consul for its desired envoy version if the task driver of the sidecar_task is not explicitly "docker". Perhaps a better heuristic would be to check if task.config["image"] exists, or maybe just always set the environment variable regardless of task driver. The downside to always setting the version environment variable is that users of non-image based task drivers (e.g. exec) will cause queries to Consul for no reason.

@shoenig
Copy link
Contributor Author

shoenig commented May 2, 2023

Closed by #17041

@shoenig shoenig closed this as completed May 2, 2023
Copy link

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
theme/consul/connect Consul Connect integration type/bug
Projects
None yet
Development

No branches or pull requests

1 participant