You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the envoy_bootstrap_hook we have logic that prevents making the query to Consul for its desired envoy version if the task driver of the sidecar_task is not explicitly "docker". Perhaps a better heuristic would be to check if task.config["image"] exists, or maybe just always set the environment variable regardless of task driver. The downside to always setting the version environment variable is that users of non-image based task drivers (e.g. exec) will cause queries to Consul for no reason.
The text was updated successfully, but these errors were encountered:
I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.
In the
envoy_bootstrap_hook
we have logic that prevents making the query to Consul for its desired envoy version if the task driver of the sidecar_task is not explicitly"docker"
. Perhaps a better heuristic would be to check iftask.config["image"]
exists, or maybe just always set the environment variable regardless of task driver. The downside to always setting the version environment variable is that users of non-image based task drivers (e.g.exec
) will cause queries to Consul for no reason.The text was updated successfully, but these errors were encountered: