Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

connect: simplify envoy sidecar when using podman #17042

Closed
shoenig opened this issue May 1, 2023 · 1 comment · Fixed by #17065
Closed

connect: simplify envoy sidecar when using podman #17042

shoenig opened this issue May 1, 2023 · 1 comment · Fixed by #17065
Labels
theme/consul/connect Consul Connect integration theme/driver/podman type/enhancement
Milestone
1.6.0

Comments

@shoenig
Copy link
Contributor

shoenig commented May 1, 2023 •
edited
Loading

When running the envoy connect sidecar as a podman job, one currently needs to configure the image manually, partly due to #17040 and partly because the image name needs to be prefixed with docker.io/.

Ideally, podman oriented clusters could use Connect jobs just like docker oriented clusters, where the connect{} block by default Just Works.

Incorporates
@shoenig shoenig mentioned this issue May 2, 2023
Merged
shoenig added a commit that referenced this issue May 2, 2023
@shoenig
connect: use heuristic to detect sidecar task driver
112879e 
This PR adds a heuristic to detect whether to use the podman task driver
for the connect sidecar proxy. The podman driver will be selected if there
is at least one task in the task group configured to use podman, and there
are zero tasks in the group configured to use docker. In all other cases
the task driver defaults to docker.

After this change, we should be able to run typical Connect jobspecs
(e.g. nomad job init [-short] -connect) on Clusters configured with the
podman task driver, without modification to the job files.

Closes #17042
@shoenig shoenig added this to the 1.6.0 milestone May 3, 2023
@shoenig shoenig mentioned this issue May 3, 2023
Closed
shoenig added a commit that referenced this issue May 5, 2023
@shoenig
connect: use heuristic to detect sidecar task driver (#17065)
0c5070a 
* connect: use heuristic to detect sidecar task driver

This PR adds a heuristic to detect whether to use the podman task driver
for the connect sidecar proxy. The podman driver will be selected if there
is at least one task in the task group configured to use podman, and there
are zero tasks in the group configured to use docker. In all other cases
the task driver defaults to docker.

After this change, we should be able to run typical Connect jobspecs
(e.g. nomad job init [-short] -connect) on Clusters configured with the
podman task driver, without modification to the job files.

Closes #17042

* golf: cleanup driver detection logic
@github-actions GitHub Actions
Copy link

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
theme/consul/connect Consul Connect integration theme/driver/podman type/enhancement
Projects
None yet
Milestone
1.6.0
Development

Successfully merging a pull request may close this issue.

connect: use heuristic to detect sidecar task driver hashicorp/nomad
1 participant
@shoenig