-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nds: add validation for tls_skip_verify
#18333
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tls_skip_verify
jrasell
approved these changes
Aug 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with a minor comment about the error generation.
shoenig
approved these changes
Aug 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; just noting there is an issue for adding support for this in #16213
lgfa29
added a commit
that referenced
this pull request
Aug 26, 2023
lgfa29
added a commit
that referenced
this pull request
Aug 26, 2023
lgfa29
added a commit
that referenced
this pull request
Aug 26, 2023
lgfa29
added a commit
that referenced
this pull request
Aug 26, 2023
Co-authored-by: Luiz Aoqui <luiz@hashicorp.com>
lgfa29
added a commit
that referenced
this pull request
Aug 26, 2023
Co-authored-by: Luiz Aoqui <luiz@hashicorp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport/1.4.x
backport to 1.4.x release line
backport/1.5.x
backport to 1.5.x release line
backport/1.6.x
backport to 1.6.x release line
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TLSSkipVerify
is ignored for Nomad service checks.