Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nds: add validation for tls_skip_verify #18333

Merged
merged 3 commits into from
Aug 25, 2023

Conversation

lgfa29
Copy link
Contributor

@lgfa29 lgfa29 commented Aug 25, 2023

TLSSkipVerify is ignored for Nomad service checks.

@lgfa29 lgfa29 added backport/1.4.x backport to 1.4.x release line backport/1.5.x backport to 1.5.x release line backport/1.6.x backport to 1.6.x release line labels Aug 25, 2023
@lgfa29 lgfa29 changed the title nds: add validation to tls_skip_verify nds: add validation for tls_skip_verify Aug 25, 2023
Copy link
Member

@jrasell jrasell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with a minor comment about the error generation.

nomad/structs/services.go Outdated Show resolved Hide resolved
Copy link
Member

@shoenig shoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; just noting there is an issue for adding support for this in #16213

@lgfa29 lgfa29 merged commit da830b1 into main Aug 25, 2023
23 of 25 checks passed
@lgfa29 lgfa29 deleted the b-add-tls-skip-verify-nds-validation branch August 25, 2023 15:55
lgfa29 added a commit that referenced this pull request Aug 26, 2023
lgfa29 added a commit that referenced this pull request Aug 26, 2023
lgfa29 added a commit that referenced this pull request Aug 26, 2023
lgfa29 added a commit that referenced this pull request Aug 26, 2023
Co-authored-by: Luiz Aoqui <luiz@hashicorp.com>
lgfa29 added a commit that referenced this pull request Aug 26, 2023
Co-authored-by: Luiz Aoqui <luiz@hashicorp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.4.x backport to 1.4.x release line backport/1.5.x backport to 1.5.x release line backport/1.6.x backport to 1.6.x release line
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants