Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of nds: add validation for tls_skip_verify into release/1.5.x #18336

Conversation

hc-github-team-nomad-core
Copy link
Contributor

Backport

This PR is auto-generated from #18333 to be assessed for backporting due to the inclusion of the label backport/1.5.x.

🚨

Warning automatic cherry-pick of commits failed. If the first commit failed,
you will see a blank no-op commit below. If at least one commit succeeded, you
will see the cherry-picked commits up to, not including, the commit where
the merge conflict occurred.

The person who merged in the original PR is:
@lgfa29
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.

merge conflict error: POST https://api.github.com/repos/hashicorp/nomad/merges: 409 Merge conflict []

The below text is copied from the body of the original PR.


TLSSkipVerify is ignored for Nomad service checks.


Overview of commits

@hc-github-team-nomad-core hc-github-team-nomad-core force-pushed the backport/b-add-tls-skip-verify-nds-validation/previously-renewing-flea branch from 56573cd to 2219a83 Compare August 25, 2023 15:55
@hc-github-team-nomad-core hc-github-team-nomad-core force-pushed the backport/b-add-tls-skip-verify-nds-validation/previously-renewing-flea branch from 2219a83 to 56573cd Compare August 25, 2023 15:55
@hashicorp-cla
Copy link

hashicorp-cla commented Aug 25, 2023

CLA assistant check
All committers have signed the CLA.

@lgfa29 lgfa29 force-pushed the backport/b-add-tls-skip-verify-nds-validation/previously-renewing-flea branch from cb30933 to f662eb6 Compare August 26, 2023 01:46
@lgfa29 lgfa29 marked this pull request as ready for review August 26, 2023 01:49
@lgfa29 lgfa29 merged commit b6dd1e6 into release/1.5.x Aug 26, 2023
24 checks passed
@lgfa29 lgfa29 deleted the backport/b-add-tls-skip-verify-nds-validation/previously-renewing-flea branch August 26, 2023 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants