Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consul.partition fingerprint generates warning logs on CE #19756

Closed
tgross opened this issue Jan 17, 2024 · 4 comments · Fixed by #19923
Closed

consul.partition fingerprint generates warning logs on CE #19756

tgross opened this issue Jan 17, 2024 · 4 comments · Fixed by #19923
Assignees
@tgross
Labels
stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/consul type/bug
Milestone
1.7.x

Comments

@tgross
Copy link
Member

tgross commented Jan 17, 2024

The Consul fingerprint for Nomad CE generates a warning log after 1.7.3. I added support for fingerprinting the Consul admin partition in #19485 and tested it with combinations of Nomad CE/ENT and Consul CE/ENT. Unfortunately I apparently missed that if you fingerprint Consul CE from this code, you get a valid fingerprint and working Consul, but noise in your logs.

The "extractor" for the partition returns "", false, which the implementation treats as a warning. If we returned "", true, we wouldn't get the warning but we'd get a useless fingerprint value of consul.partition = "" which we don't want either. So we need to adjust the implementation to handle empty values differently too.

Reported in #19485 (comment)
@tgross tgross added this to the 1.7.x milestone Jan 17, 2024
@tgross tgross self-assigned this Jan 17, 2024
@tgross tgross mentioned this issue Jan 17, 2024
Merged
@johnnyplaydrums johnnyplaydrums mentioned this issue Jan 25, 2024
Closed
@maxless
Copy link

maxless commented Feb 2, 2024 •
edited
Loading

@tgross Is there a way to disable this message through config currently if you're not using Consul?

@tgross
Copy link
Member Author

tgross commented Feb 2, 2024

Unfortunately no. When you leave out the consul config, Nomad generates a default one. This is something we've discussed removing entirely to make it nicer to run Nomad without Consul (as we do for the vault.enabled flag), but it hasn't managed to get to the top of the priority pile. So we've got to fix the fingerprint... I'll try to get this into the next regular release.

@maxless
Copy link

maxless commented Feb 5, 2024

Okay, thanks.

@lgfa29 lgfa29 added the stage/accepted Confirmed, and intend to work on. No timeline committment though. label Feb 5, 2024
tgross added a commit that referenced this issue Feb 8, 2024
@tgross
fingerprint: eliminate spurious warning logs with Consul CE
587a270 
Support for fingerprinting the Consul admin partition was added in #19485. But
when the client fingerprints Consul CE, it gets a valid fingerprint and working
Consul but with a warn-level log. Return "ok" from the partition extractor, but
also ensure that we only add the Consul attribute if it actually has a value.

Fixes: #19756
@tgross tgross mentioned this issue Feb 8, 2024
Merged
@tgross
Copy link
Member Author

tgross commented Feb 8, 2024

Will be fixed in #19923, planned for shipping in Nomad 1.7.5

@tgross tgross closed this as completed in 62c57d2 Feb 9, 2024
Merged
nvanthao pushed a commit to nvanthao/nomad that referenced this issue Mar 1, 2024
@tgross @nvanthao
fingerprint: eliminate spurious warning logs with Consul CE (hashicor…
366abc2 
…p#19923)

Support for fingerprinting the Consul admin partition was added in hashicorp#19485. But
when the client fingerprints Consul CE, it gets a valid fingerprint and working
Consul but with a warn-level log. Return "ok" from the partition extractor, but
also ensure that we only add the Consul attribute if it actually has a value.

Fixes: hashicorp#19756
nvanthao pushed a commit to nvanthao/nomad that referenced this issue Mar 1, 2024
@tgross @nvanthao
fingerprint: eliminate spurious warning logs with Consul CE (hashicor…
a027a13 
…p#19923)

Support for fingerprinting the Consul admin partition was added in hashicorp#19485. But
when the client fingerprints Consul CE, it gets a valid fingerprint and working
Consul but with a warn-level log. Return "ok" from the partition extractor, but
also ensure that we only add the Consul attribute if it actually has a value.

Fixes: hashicorp#19756
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tgross tgross

Labels
stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/consul type/bug
Projects
Nomad - Community Issues Triage
Archived in project
Milestone
1.7.x
Development

Successfully merging a pull request may close this issue.

fingerprint: eliminate spurious warning logs with Consul CE hashicorp/nomad
3 participants
@lgfa29 @tgross @maxless