Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"stats not implemented for rkt" warning should only be emitted once #1986

Closed
doherty opened this issue Nov 13, 2016 · 2 comments
Closed

"stats not implemented for rkt" warning should only be emitted once #1986

doherty opened this issue Nov 13, 2016 · 2 comments

Comments

@doherty
Copy link

doherty commented Nov 13, 2016

If filing a bug please include the following:

Nomad version

0.4.1

Operating system and Environment details

linux w/ rkt

Issue

Nomad spews the following log line:

    2016/11/12 19:09:58.484502 [WARN] client: error fetching stats of task go-kit-demo: stats not implemented for rkt

This is not useful; it should only be logged once. (use sync.Once or a helper in your log package)

Reproduction steps

Run Nomad on a system set up with rkt. Submit a job using the rkt driver. Observe the message shown above being logged every 1s.

@diptanu added this log line in 1cae57a

@doherty
Copy link
Author

doherty commented Nov 13, 2016

Correction: logs once per second per task/replica

@dadgar dadgar added this to the v0.5.1 milestone Nov 13, 2016
dadgar added a commit that referenced this issue Jan 9, 2017
This PR makes us only try to collect stats once if the Driver doesn't
support collecting stats.

Fixes #1986
@tgross tgross modified the milestones: near-term, unscheduled Jan 9, 2020
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants