Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

raft: upgrade to v1.7.0 which introduces pre-vote extension #20335

Closed
jrasell opened this issue Apr 9, 2024 · 0 comments
Closed

raft: upgrade to v1.7.0 which introduces pre-vote extension #20335

jrasell opened this issue Apr 9, 2024 · 0 comments
Assignees
@pkazmierczak @jrasell
Labels
hcc/jira stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/autopilot theme/raft type/enhancement

Comments

@jrasell
Copy link
Member

jrasell commented Apr 9, 2024 •
edited
Loading

In the near future, Raft will release v1.7.0 which introduces the pre-vote extension: hashicorp/raft#530

The feature particularly improves cluster stability when a Nomad server is partition from the cluster, but rejoins at a later date. The PR has a conclusive writeup.

In order to update Nomad we will want to decide if the new preVoteDisabled configuration flag is exposed to operators and perform testing. The testing should include:

  • upgrade testing with mixed Raft versions
  • leadership transitions
  • server partitioning and rejoining
  • pre-vote interactions with Autopilot
  • load testing
@jrasell jrasell added type/enhancement theme/autopilot theme/raft stage/accepted Confirmed, and intend to work on. No timeline committment though. labels Apr 9, 2024
@tgross tgross moved this to Needs Roadmapping in Nomad - Community Issues Triage Jun 24, 2024
@schmichael schmichael mentioned this issue Sep 20, 2024
Merged
schmichael added a commit that referenced this issue Sep 20, 2024
@schmichael
deps: upgrade raft from v1.6.1 -> v1.7.1
ca340bd 
Fixes #20335

The major change between Raft v1.6 -> v1.7 was the introduction of the
Prevote feature. Before Prevote, when a partitioned node rejoins a
cluster it may cause an election even if the cluster was stable. Prevote
can avoid this useless election so reintroducing partitioned servers to
an otherwise stable cluster becomes seamless.

Full details: hashicorp/raft#530

In #20335 we discussed whether or not to add a configuration option to
disable prevote in case bugs were discovered. While bugs have been found
(hence the v1.7.1 version as opposed to v1.7.0), I'm choosing to follow
Vault's lead of straightfordwardly bumping the raft dependency:
hashicorp/vault#27605 and hashicorp/vault#28218
@github-project-automation github-project-automation bot moved this from Needs Roadmapping to Done in Nomad - Community Issues Triage Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pkazmierczak pkazmierczak

@jrasell jrasell

Labels
hcc/jira stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/autopilot theme/raft type/enhancement
Projects
Nomad - Community Issues Triage
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pkazmierczak @jrasell