Allow to set the nodename on telemetry #2098
Conversation
jorgemarey
changed the title
| @@ -621,6 +621,9 @@ func (c *Command) setupTelemetry(config *Config) error { | |||
|
|
|||
| metricsConf := metrics.DefaultConfig("nomad") | |||
| metricsConf.EnableHostname = !telConfig.DisableHostname | |||
| if telConfig.UseName { | |||
There was a problem hiding this comment.
Can we just detect if UseName is set and set the appropriate EnableHostname. In the docs we should note if set it will override DisableHostname
| @@ -527,6 +527,7 @@ func parseTelemetry(result **Telemetry, list *ast.ObjectList) error { | |||
| "statsite_address", | |||
| "statsd_address", | |||
| "disable_hostname", | |||
| "use_name", | |||
|
Changed! |
|
@jorgemarey Some weird rebasing going on there? Let me know if you want to fix it or I can open another PR and just grab your changes? |
jorgemarey
force-pushed
the
f-telemetry-nodename
branch
from
d677d59
to
a39cebb
Compare
|
I think I fix the problem. Some tests failed, do I need to do something else? |
|
@jorgemarey Thanks 👍 |
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Fixes #2094