Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image based drivers should not include host env vars #2211

Closed
schmichael opened this issue Jan 18, 2017 · 1 comment
Closed

Image based drivers should not include host env vars #2211

schmichael opened this issue Jan 18, 2017 · 1 comment

Comments

@schmichael
Copy link
Member

Image based drivers such as Docker often have their own environment variables such as PATH. #2054 (first released in 0.5.2) caused host environment variables, such as PATH, to be added to all image based drivers and override any existing environment variables.

Only exec based drivers should include host environment variables by default. Image based drivers like Docker should not.

The documentation also needs updating.

Original report: https://groups.google.com/d/msg/nomad-tool/uP1tKiOLLmk/cnG_dFZzFQAJ

@schmichael schmichael self-assigned this Jan 18, 2017
@schmichael schmichael added this to the v0.5.3 milestone Jan 18, 2017
schmichael added a commit that referenced this issue Jan 18, 2017
Add detailed tests for GetTaskEnv to avoid this issue happening again!

Fixes #2211
@tgross tgross modified the milestones: near-term, unscheduled Jan 9, 2020
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants