-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Local tests are failing in env_aws_test.go #224
Comments
Are you running the test from an EC2 VM? I think if there actually is a metadata server at the default URL the test will fail in the way you showed above. |
This is a GCE VM. I was expecting the tests to be skipped if they cannot be run. |
I wonder if your change #215 will fix this. |
Ah, that will also trigger the problem then. In the master branch the AWS fingerprinter thinks it's on AWS on a GCE node as well. Yes, #215 will fix the AWS test issue on GCE, though the GCE fingerprint test will fail since the "non-GCE" test will successfully contact the test server. I'll update the new GCE test to not do that. |
Updated the AWS test as well, so this issue should no longer occur on GCE and AWS once the PR merges. |
Thanks! |
Delete temporary snapshot files when there are errors in saving.
I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues. |
This is what I see
The text was updated successfully, but these errors were encountered: