Local tests are failing in env_aws_test.go

[achanda]

This is what I see

Abhishek@dev:~/gosrc/src/github.com/hashicorp/nomad$ make test
--> Installing build dependencies
--> Building nomad
--> Running tests
ok      github.com/hashicorp/nomad  0.008s
ok      github.com/hashicorp/nomad/api  3.984s
ok      github.com/hashicorp/nomad/client   3.630s
ok      github.com/hashicorp/nomad/client/allocdir  0.006s
ok      github.com/hashicorp/nomad/client/config    0.005s
ok      github.com/hashicorp/nomad/client/driver    27.662s
ok      github.com/hashicorp/nomad/client/driver/args   0.002s
ok      github.com/hashicorp/nomad/client/driver/environment    0.002s
ok      github.com/hashicorp/nomad/client/executor  0.006s
--- FAIL: TestEnvAWSFingerprint_nonAws (0.40s)
    env_aws_test.go:27: Should be false without test server
--- FAIL: TestNetworkFingerprint_notAWS (0.00s)
    env_aws_test.go:212: Should not apply
2015/10/06 22:56:37 [WARN] fingerprint.network: Unable to parse Speed in output of '/sbin/ethtool eth0'
2015/10/06 22:56:37 [WARN] fingerprint.network: Unable to read link speed from /sys/class/net/eth0/speed
2015/10/06 22:56:37 [DEBUG] fingerprint.network: Unable to read link speed; setting to default 100
FAIL
FAIL    github.com/hashicorp/nomad/client/fingerprint   0.422s
?       github.com/hashicorp/nomad/client/testutil  [no test files]
ok      github.com/hashicorp/nomad/command  2.930s
ok      github.com/hashicorp/nomad/command/agent    13.839s
?       github.com/hashicorp/nomad/demo/digitalocean/app    [no test files]
?       github.com/hashicorp/nomad/helper/discover  [no test files]
ok      github.com/hashicorp/nomad/helper/flag-slice    0.002s
ok      github.com/hashicorp/nomad/helper/gated-writer  0.002s
ok      github.com/hashicorp/nomad/jobspec  0.010s
ok      github.com/hashicorp/nomad/nomad    3.430s
?       github.com/hashicorp/nomad/nomad/mock   [no test files]
ok      github.com/hashicorp/nomad/nomad/state  0.009s
ok      github.com/hashicorp/nomad/nomad/structs    0.010s
ok      github.com/hashicorp/nomad/scheduler    0.019s
ok      github.com/hashicorp/nomad/testutil 0.005s
make: *** [test] Error 123

[dimfeld]

Are you running the test from an EC2 VM? I think if there actually is a metadata server at the default URL the test will fail in the way you showed above.

[achanda]

This is a GCE VM. I was expecting the tests to be skipped if they cannot be run.

[achanda]

I wonder if your change #215 will fix this.

[dimfeld]

Ah, that will also trigger the problem then. In the master branch the AWS fingerprinter thinks it's on AWS on a GCE node as well. Yes, #215 will fix the AWS test issue on GCE, though the GCE fingerprint test will fail since the "non-GCE" test will successfully contact the test server. I'll update the new GCE test to not do that.

[dimfeld]

Updated the AWS test as well, so this issue should no longer occur on GCE and AWS once the PR merges.

[achanda]

Thanks!

[dimfeld]

My PR isn't merged yet, but @dadgar checked in the AWS portion of it to master in ae6829c, so I think this one can be closed.

[github-actions]

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.