-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Periodic job transitions to dead on update #2268
Comments
Haha, i've always thought that was the intended state for a periodic job waiting for something to execute... interesting :D |
Yeah, I was confused with the 'dead' status. Even with the 'dead' status the periodic job still appears to run. |
I wish I would have seen this issue a week ago! |
@dadgar Is this simply a matter of setting status correctly when a periodic job is updated? I'd like to submit a PR if so. |
This PR fixes an issue in which a periodic job would incorrectly transistion to status dead. Fixes #2268
@briansorahan Appreciate the offer! I went ahead and fixed it as it is somewhat subtle! In the meantime, the periodic job will have the incorrect state but it will function correctly. We should have a release out soon though! |
@dadgar Thank you! |
I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues. |
Steps to reproduce
The text was updated successfully, but these errors were encountered: