Periodic job transitions to dead on update

[dadgar]

Steps to reproduce

1. nomad run example.nomad
2. edit test -> test2
3. nomad run example.nomad
4. nomad status example: It will be dead.

job "example" {
  type = "batch"
  datacenters = ["dc1"]
  periodic {
     cron = "* * * * * *"
     prohibit_overlap = true
  }
  group "foo" {
    task "foo" {
      driver = "raw_exec"
      config {
        command = "echo"
        args = ["test2"]
      }
    }
  }
}

[jippi]

Haha, i've always thought that was the intended state for a periodic job waiting for something to execute... interesting :D

[sepulworld]

Yeah, I was confused with the 'dead' status. Even with the 'dead' status the periodic job still appears to run.

[briansorahan]

I wish I would have seen this issue a week ago!
We just started implementing a bulk update to all our periodic jobs and have run into this.

[briansorahan]

@dadgar Is this simply a matter of setting status correctly when a periodic job is updated? I'd like to submit a PR if so.
It seems to me like @sepulworld 's comment is correct. The periodic jobs that are marked as "dead" seem to be functioning correctly

[dadgar]

@briansorahan Appreciate the offer! I went ahead and fixed it as it is somewhat subtle! In the meantime, the periodic job will have the incorrect state but it will function correctly. We should have a release out soon though!

[briansorahan]

@dadgar Thank you!

[github-actions]

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.