Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Docker Credential Helper #2334

Closed
bantonj opened this issue Feb 19, 2017 · 8 comments
Closed

[feature] Docker Credential Helper #2334

bantonj opened this issue Feb 19, 2017 · 8 comments

Comments

@bantonj
Copy link

bantonj commented Feb 19, 2017

It would be very useful if nomad supported Docker Credential Helpers. It would be especially helpful for Amazon's ECR which only supports logins that last for 12 hours. I made this same feature request to go-dockerclient, and it doesn't sound like there is much interest in adding it there.

@dadgar
Copy link
Contributor

dadgar commented Feb 27, 2017

Hey @bantonj,

How will this help your problem of having to refresh the credentials? This just seems to be a different credential store?

@bantonj
Copy link
Author

bantonj commented Feb 27, 2017

@dadgar This would make the credential store refresh the credentials transparently, while right now I have to have a cron running in the background to keep refreshing the docker login.

@dadgar
Copy link
Contributor

dadgar commented Feb 27, 2017

@bantonj Cool! Would you mind linking docs and/or examples of this being integrated in other projects?

@bantonj
Copy link
Author

bantonj commented Feb 28, 2017

@dadgar I couldn't find anything in other projects, but here is how the docker cli does it. And here are the Docker docs regarding credential store helpers.

@rawler
Copy link

rawler commented May 15, 2017

I need this too. I will look into making a patch

@dadgar
Copy link
Contributor

dadgar commented May 31, 2017

Fixed by #2651

@dadgar dadgar closed this as completed May 31, 2017
@discobean
Copy link

Thanks @rawler this is a big help and works great!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants