Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nomad needs to sanitize the injected env var names #2405

Closed
timperrett opened this issue Mar 7, 2017 · 3 comments
Closed

Nomad needs to sanitize the injected env var names #2405

timperrett opened this issue Mar 7, 2017 · 3 comments
Assignees
Milestone

Comments

@timperrett
Copy link

lets say i have a job callled foo-bar. Nomad will at runtime inject an env var, NOMAD_ADDR_foo-bar_whatever. Given that dashes are not allowed in env vars names, they must be sanitized by nomad for the bash-allowed var syntax.

@schmichael
Copy link
Member

Attached a binary built from #2406 if you want to test it. NBD

linux_amd64.zip

schmichael added a commit that referenced this issue Mar 7, 2017
@schmichael
Copy link
Member

Missed an env var with that first pass. Got 'em all now.

linux_amd64.zip

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants