Replace "-" in port labels with "_" for env vars #2406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dadgar
reviewed
Mar 7, 2017
client/driver/env/env.go
Outdated
| @@ -147,6 +147,8 @@ func (t *TaskEnvironment) Build() *TaskEnvironment { | |||
| // Build the ports | |||
| for _, network := range t.Networks { | |||
| for label, value := range network.MapLabelToValues(nil) { | |||
| // Replace dashes with underscores #2405 | |||
| label = strings.Replace(label, "-", "_", -1) | |||
There was a problem hiding this comment.
I would just move this to the bottom and go through all keys and sanitize them.
schmichael
force-pushed
the
b-2405-dashes-in-env-vars
branch
from
45579c8
to
a9e3f2c
Compare
dadgar
reviewed
Mar 7, 2017
| </table> | ||
|
|
||
| Port labels and task names will have any dashes `-` in their names replaced by |
There was a problem hiding this comment.
~> Port labels and task names will have any dashes `-` in their names replaced by
underscores `_` when they're used in environment variable names such as
`NOMAD_ADDR_<task>_<label>`.
This will make it a popped out bubble to draw attention. See yellow box: https://www.consul.io/docs/guides/outage.html
Up to you to include.
dadgar
approved these changes
Mar 7, 2017
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2405