Add the Nomad agent version to the node-status CLI output.

[jrasell]

The Nomad agent version will now be displayed when running the nomad node-status command which brings the command inline with the nomad server-members command which already displays the version information.

Closes #2993

[dadgar]

Can you remove from the Node struct and only add to the stub

[dadgar]

Build -> Version

[dadgar]

You can pull this out of the attributes map. The key is nomad.version

[dadgar]

Can we keep it for only -verbose. Most people aren't running mixed clusters so it will just needlessly expand the width of output

[jrasell]

Any thoughts on how to best accomplish this @dadgar? From my understanding verbose is currently only used to determine the length of the nodeID displayed. I am trying to avoid using numerous else ifs to reconcile the differences between the -allocs and -verbose flag usage:

if c.list_allocs && !c.verbose {
    out[0] = "ID|DC|Name|Class|Drain|Status|Running Allocs"
} else if c.list_allocs && c.verbose {
    out[0] = "ID|DC|Name|Class|Build|Drain|Status|Running Allocs"

[dadgar]

Hmm, you may want to try breaking it into:

out := "ID|DC|Name|Class|"
if c.verbose {
  out += "Version|"
}
out += "Drain|Status"
if c.list_allocs {
  out += "|Running Allocs"
}

[jrasell]

Output examples:
$ ./jrasell-nomad node-status
ID        DC   Name           Class   Drain  Status
f88d3097  dc1  voyager.local  <none>  false  ready

$ ./jrasell-nomad node-status -verbose
ID                                    DC   Name           Class   Version   Drain  Status
f88d3097-7498-e7a7-15e2-5a17b4de10b2  dc1  voyager.local  <none>  0.6.0dev  false  ready

$ ./jrasell-nomad node-status -verbose -allocs
ID                                    DC   Name           Class   Version   Drain  Status  Running Allocs
f88d3097-7498-e7a7-15e2-5a17b4de10b2  dc1  voyager.local  <none>  0.6.0dev  false  ready   0

$ ./jrasell-nomad node-status -allocs
ID        DC   Name           Class   Drain  Status  Running Allocs
f88d3097  dc1  voyager.local  <none>  false  ready   0

[jrasell]

I don't think the failure is related to this change.

[jrasell]

@dadgar anything else I can do to get this merged in?

[dadgar]

Sorry for the delay! LGTM

[hsmade]

thx @jrasell and @dadgar !

[github-actions]

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.