-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the Nomad agent version to the node-status CLI output. #3002
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -996,6 +996,9 @@ type Node struct { | |
// together for the purpose of determining scheduling pressure. | ||
NodeClass string | ||
|
||
// Build represents the Nomad version the node is running | ||
Build string | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you remove from the |
||
|
||
// ComputedClass is a unique id that identifies nodes with a common set of | ||
// attributes and capabilities. | ||
ComputedClass string | ||
|
@@ -1057,6 +1060,7 @@ func (n *Node) Stub() *NodeListStub { | |
Datacenter: n.Datacenter, | ||
Name: n.Name, | ||
NodeClass: n.NodeClass, | ||
Build: n.Build, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You can pull this out of the attributes map. The key is |
||
Drain: n.Drain, | ||
Status: n.Status, | ||
StatusDescription: n.StatusDescription, | ||
|
@@ -1072,6 +1076,7 @@ type NodeListStub struct { | |
Datacenter string | ||
Name string | ||
NodeClass string | ||
Build string | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
Drain bool | ||
Status string | ||
StatusDescription string | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we keep it for only
-verbose
. Most people aren't running mixed clusters so it will just needlessly expand the width of outputThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any thoughts on how to best accomplish this @dadgar? From my understanding verbose is currently only used to determine the length of the nodeID displayed. I am trying to avoid using numerous else ifs to reconcile the differences between the -allocs and -verbose flag usage:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, you may want to try breaking it into: