-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retrieving stats from CLI doesn't properly support TLS #3013
Comments
I'm having the same issue. Also node-status seems to be affected as well
|
@dsolsona Thanks for the report! The good news its it's the same underlying call in the |
Fixes #3013 It's a little weird that Client now has a method for returning a NewClient, but it's a convenient way to dedupe the logic to connect-directly-to-a-node which is nontrivial and had sutble differences between locations.
Thanks! |
Hi @schmichael I've tested Nomad 0.6.2 and now I'm getting a completely different error
It seems that somehow the region is getting lost based on the log output. On the Nomad client I'm seeing
Both servers and clients have the right region in them and the certificates were created with the right region too. If you think this issue is not the best place to discuss this I can create a new one or move this to the mailing list, but it seems kind of related to the latest Nomad release (0.6.2) |
This PR fixes the construction of the TLSServerName when connecting to a node that has TLS enabled and adds tests for all possible permutations. Fixes #3013
Hi @dadgar I've tested the binary and now I get
Still using the wrong region, but at least now it uses a region ;) |
@dsolsona Did you set the region to aws? You have two ways
|
Oh right, exporting NOMAD_REGION does work flawlessly I guess I was expecting it would read the region from the nomad configuration file. Thanks for fixing this so quickly! |
I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues. |
I think this is a similar bug as #2490.
Original report by @pznamensky:
I've found that at least
nomad alloc-status $alloc-id
doesn't work as expected (for me).This doesn't work in case of using
cli
orclient
certs.Is this expected behavior?
The text was updated successfully, but these errors were encountered: