-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bug/question] LC_ALL set to C on executors when using raw driver #3036
Comments
@nugend Is it an environment variable that you are starting Nomad with. The env-vars are passed through from the host. You can restrict that using either a white or black list: https://www.nomadproject.io/docs/agent/configuration/client.html#quot-env-blacklist-quot- |
@dadgar Nope.
|
I'm going to try using the blacklist now though. I'm definitely not setting that anywhere though. |
Setting the blacklist does prevent the environment variable from propagating to the executor's subprocess, but the variable remains set on the executor itself. |
@schmichael identified that this is being caused by
I'll file a report upstream. |
@nugend If it prevents it from propagating to the actual task, isn't that enough? |
@dadgar Well, sure. It's fine as a workaround as long as upstream gets it fixed. If they come back with a can't/won't, then I guess you should add it to the default blacklist (and you never have a problem with something in the agent/executor assuming a Unicode locale but getting a C one). And also, I mean, there is the whole issue that this means that LC_ALL's value can't be correctly propagated in that case because the dependency is forcing it to "C". I don't have an issue with it being system default, but I try not to make assumptions about what other users need. |
@schmichael Change was accepted upstream |
Thanks for the report and helping out @nugend 👍 |
I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues. |
Not sure if this intentional or a golang thing or what. It's breaking a script that assumes stdout is UTF-8 encoded. I can work around it, but I don't really expect the executor to work this way without a reason.
Nomad version
Nomad v0.6.0
Operating system and Environment details
3.10.0-327.36.3.el7.x86_64
Issue
The nomad executor has the following environment variables set in addition to the ones set on the agent
LC_ALL being set that way breaks a script I'm using which normally assumes UTF-8. I can override if necessary, just wondering if this is intentional or not.
Reproduction steps
Reproduced with the following nomad job:
Nomad Client logs (if appropriate)
Output is "C"
The text was updated successfully, but these errors were encountered: