Fix TLSServerName for Node API Client #3127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes the construction of the TLSServerName when connecting to a node that has TLS enabled and adds tests for all possible permutations. Fixes #3013
chelseakomlo
approved these changes
Aug 29, 2017
api/api.go
Outdated
| type nodeLookup func(nodeID string, q *QueryOptions) (*Node, *QueryMeta, error) | ||
|
|
||
| // getNodeClientImpl is the implementation of creating a API client for | ||
| // contacting a node. It is takes a function to lookup the node such that it can |
api/api.go
Outdated
| @@ -316,6 +331,10 @@ func (c *Client) GetNodeClient(nodeID string, q *QueryOptions) (*Client, error) | |||
| region = q.Region | |||
| } | |||
|
|
|||
| if region == "" { | |||
There was a problem hiding this comment.
This logic is a bit confusing with 329-332. Is there a way (case statement or "else if") to have region only be assigned a value once?
api/api.go
Outdated
| return c.getNodeClientImpl(nodeID, q, c.Nodes().Info) | ||
| } | ||
|
|
||
| // nodeLookup is used to lookup a node |
There was a problem hiding this comment.
Maybe a bit more detail in the comment here
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the construction of the TLSServerName when connecting to a
node that has TLS enabled and adds tests for all possible permutations.
Fixes #3013
Fixes #3126