Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consul check changing due to randomly output on /agent/servers #3211

Closed
jorgemarey opened this issue Sep 14, 2017 · 1 comment
Closed

Consul check changing due to randomly output on /agent/servers #3211

jorgemarey opened this issue Sep 14, 2017 · 1 comment
Labels
theme/discovery type/bug

Comments

@jorgemarey
Copy link
Contributor

jorgemarey commented Sep 14, 2017 •
edited

Hi,

I found out that the blocking queries that we we're performing over consul healthchecks were changing usually.

Doing some debuging I saw that this behaviour is triggered by nomad. The check that nomad registers on consul is on /v1/agent/servers. The problem is that this endpoint returns the servers randomly (ordered by priority for what I saw on the code, but it seems to change frequently). As is said in this comment on consul, chaging the output of the check should be avoided. Could this output be changed to be ordered or changed the check endpoint registered on consul?

Thanks!
dadgar added a commit that referenced this issue Sep 14, 2017
@dadgar
Sort /v1/agent/servers output
8f44601 
This PR sorts the output of the endpoint since its results are used as
part of Consul checks to avoid the value changing unnecessarily.

Fixes #3211
@dadgar dadgar mentioned this issue Sep 14, 2017
Merged
dadgar added a commit that referenced this issue Sep 14, 2017
@dadgar
Sort /v1/agent/servers output
e25dff5 
This PR sorts the output of the endpoint since its results are used as
part of Consul checks to avoid the value changing unnecessarily.

Fixes #3211
dadgar added a commit that referenced this issue Sep 14, 2017
@dadgar
Sort /v1/agent/servers output
ea57432 
This PR sorts the output of the endpoint since its results are used as
part of Consul checks to avoid the value changing unnecessarily.

Fixes #3211
@github-actions
Copy link

github-actions bot commented Dec 8, 2022

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
theme/discovery type/bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dadgar @jorgemarey