Sort /v1/agent/servers output #3214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chelseakomlo
approved these changes
Sep 14, 2017
command/agent/agent_endpoint_test.go
Outdated
| } | ||
| if foundCount != len(expected) { | ||
| t.Fatalf("bad servers result") | ||
| if !reflect.DeepEqual(servers, expected) { |
There was a problem hiding this comment.
I think you can use assert.Equal here, as it looks like the library is using DeepEquals: https://github.com/stretchr/testify/blob/master/assert/assertions.go#L53
This PR sorts the output of the endpoint since its results are used as part of Consul checks to avoid the value changing unnecessarily. Fixes #3211
dadgar
force-pushed
the
f-agent-servers
branch
from
1d08da5
to
d0a9389
Compare
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sorts the output of the endpoint since its results are used as
part of Consul checks to avoid the value changing unnecessarily.
Fixes #3211