Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There is no consul CLI config option #3304

Closed
flybd5 opened this issue Oct 1, 2017 · 10 comments
Closed

There is no consul CLI config option #3304

flybd5 opened this issue Oct 1, 2017 · 10 comments

Comments

@flybd5
Copy link

flybd5 commented Oct 1, 2017

Nomad version

All

Issue

There is a way to config the info to connect to a consul client from an hcl file but not from the command line. I checked in commands.go and nothing.

@dadgar
Copy link
Contributor

dadgar commented Oct 2, 2017

PRs for this would definitely be welcome. Could look at the Vault flags for guidance.

@flybd5
Copy link
Author

flybd5 commented Oct 2, 2017

I don't code in Go, sorry.

@dadgar
Copy link
Contributor

dadgar commented Oct 2, 2017

Git jargon for "pull request".

@jrasell
Copy link
Member

jrasell commented Oct 5, 2017

@dadgar I can take this one if you want? I assume its everything listed here to go as a CLI flag?

@flybd5
Copy link
Author

flybd5 commented Oct 5, 2017

I would also suggest a cross-check to make sure all config file options can be done in CLI and vice-versa.

jrasell added a commit to jrasell/nomad that referenced this issue Oct 5, 2017
This update introduces command line flags for all Consul options
thus allowing users to both use a config file and CLI options to
configure Consul.

Website documentation has also been updated.

Closes hashicorp#3304
@dadgar
Copy link
Contributor

dadgar commented Oct 5, 2017

@flybd5 We don't aim to have full parity with the config file. Just the most common options should be available as flags.

@flybd5
Copy link
Author

flybd5 commented Oct 5, 2017

I think you should. Some people like to use config files but others prefer to set up things on the command line exclusively. When setting up systemctl definition files I prefer for the config to be self-contained using the CLI.

@shantanugadgil
Copy link
Contributor

@flybd5
I would sort-of disagree, I tend to use only the single "config directory" parameter, so that I can happily tweak the config files within the config directory.

These becomes very easy in a system where some sort of configuration management system like SALT/Ansible/(even Packer) is used to deploy Consul/Nomad.

Cheers,
Shantanu

@flybd5
Copy link
Author

flybd5 commented Oct 6, 2017

@shantanugadgil The point is that there is no justification to force the developer to accept one viewpoint over another. It also looks unprofessional to offer one option, but do a half-a** job of the other. The issue of config management is not relevant because you can manage systemctl files just as well as you can manage config files. Config management tools don't care about the content of the files.

@github-actions
Copy link

github-actions bot commented Dec 7, 2022

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants