Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update agent CLI to include Consul config option flags. #3327

Merged
merged 1 commit into from
Oct 5, 2017

Conversation

jrasell
Copy link
Member

@jrasell jrasell commented Oct 5, 2017

This update introduces command line flags for all Consul options thus allowing users to both use a config file and CLI options to configure Consul.

Website documentation has also been updated.

The change was tested running a local build with the command nomad agent -dev -consul-server-service-name=jrasell-nomad -consul-client-service-name=jrasell-nomad-client. Consul confirming the correct configuration:

$ curl -s localhost:8500/v1/health/checks/jrasell-nomad | jq '.[0].ServiceName'
"jrasell-nomad"

 $ curl -s localhost:8500/v1/health/checks/jrasell-nomad-client | jq '.[0].ServiceName'
"jrasell-nomad-client"

Closes #3304

This update introduces command line flags for all Consul options
thus allowing users to both use a config file and CLI options to
configure Consul.

Website documentation has also been updated.

Closes hashicorp#3304
@dadgar
Copy link
Contributor

dadgar commented Oct 5, 2017

@jrasell Awesome work!

@dadgar dadgar merged commit 262a695 into hashicorp:master Oct 5, 2017
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants