Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI does not include client certificate in all ajax requests #3701

Closed
selaux opened this issue Dec 29, 2017 · 8 comments
Closed

UI does not include client certificate in all ajax requests #3701

selaux opened this issue Dec 29, 2017 · 8 comments

Comments

@selaux
Copy link

selaux commented Dec 29, 2017

Nomad version

Nomad v0.7.1 (0b295d3)

Issue

It seems like not all ajax requests include the client certificate that was selected. E.g. when visiting the clients page, the request to /v1/status/leader returns a 400 Bad Request error because no client certificate was sent.

Listing nodes through the CLI works fine.

Reproduction steps

  • Enable tls for http
  • Visit nomad ui and select valid client certificate
  • Visit /ui/jobs -> Works as expected
  • Visit /ui/clients -> shows error page
@schmichael
Copy link
Member

We have an idea what the issue might be, but I've been unable to reproduce this bug in my browser (Google Chrome 63.0.3239.108 (Official Build) (64-bit)).

What browser are you using?

@selaux
Copy link
Author

selaux commented Jan 6, 2018

I'm using Firefox 57.0b3 (64-bit) Developer Edition.

@selaux
Copy link
Author

selaux commented Jan 6, 2018

BTW, same goes for basic auth. The header is not sent as well.

@selaux
Copy link
Author

selaux commented Jan 6, 2018

And it indeed works in chrome for me as well...

@schmichael
Copy link
Member

@selaux Thanks for testing! I think we know the fix. Should have a PR up next week for inclusion in the next release. In the meantime I'm afraid you'll have to use Chrome/Chromium. I think Firefox is actually doing the right thing here, so I hope Chrome doesn't "fix" it in the meantime!

@schmichael
Copy link
Member

Tested Firefox 57.0.4 (57.0.4+build1-0ubuntu0.17.04.1 amd64) and confirmed it does break against 0.7.1.

Fixed in #3728 but until the fix is in a release you'll have to use Chrome/Chromium I'm afraid.

Thanks for the report!

@selaux
Copy link
Author

selaux commented Jan 9, 2018

Nice. Thx for the quick fix.

@github-actions
Copy link

github-actions bot commented Dec 4, 2022

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants