-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI does not include client certificate in all ajax requests #3701
Comments
We have an idea what the issue might be, but I've been unable to reproduce this bug in my browser (Google Chrome 63.0.3239.108 (Official Build) (64-bit)). What browser are you using? |
I'm using Firefox 57.0b3 (64-bit) Developer Edition. |
BTW, same goes for basic auth. The header is not sent as well. |
And it indeed works in chrome for me as well... |
@selaux Thanks for testing! I think we know the fix. Should have a PR up next week for inclusion in the next release. In the meantime I'm afraid you'll have to use Chrome/Chromium. I think Firefox is actually doing the right thing here, so I hope Chrome doesn't "fix" it in the meantime! |
Fixes #3701 Relevant spec section: https://fetch.spec.whatwg.org/#concept-request-credentials-mode
Tested Firefox 57.0.4 ( Fixed in #3728 but until the fix is in a release you'll have to use Chrome/Chromium I'm afraid. Thanks for the report! |
Fixes #3701 Relevant spec section: https://fetch.spec.whatwg.org/#concept-request-credentials-mode
Nice. Thx for the quick fix. |
I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues. |
Nomad version
Nomad v0.7.1 (0b295d3)
Issue
It seems like not all ajax requests include the client certificate that was selected. E.g. when visiting the clients page, the request to
/v1/status/leader
returns a400 Bad Request
error because no client certificate was sent.Listing nodes through the CLI works fine.
Reproduction steps
/ui/jobs
-> Works as expected/ui/clients
-> shows error pageThe text was updated successfully, but these errors were encountered: