Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consul config: configurable Consul health check names #3988

Closed
jrasell opened this issue Mar 15, 2018 · 2 comments
Closed

Consul config: configurable Consul health check names #3988

jrasell opened this issue Mar 15, 2018 · 2 comments
Labels
theme/consul theme/discovery type/enhancement

Comments

@jrasell
Copy link
Member

jrasell commented Mar 15, 2018

In my current setup we alert based on Consul health checks and all alerts must follow a particular naming pattern in order to meet the correct alerting requirements. It would be excellent (I have checked but not found the feature detailed) if an operator could override the default 'Nomad Server *' and 'Nomad Client HTTP Check' names so that in such environments, the names can be changed to match requirement.

I would be interested in your thoughts about this feature, and I would also be happy to contribute this as I believe I understand how to implement this.
@schmichael
Copy link
Member

Sounds good! You can probably just follow client_service_name as an example of how to allow configuring the check names!

jrasell added a commit to jrasell/nomad that referenced this issue Mar 19, 2018
@jrasell
Allow Nomads Consul health checks to be configurable.
abddf1f 
This change allows the client HTTP and the server HTTP, Serf and
RPC health check names within Consul to be configurable with the
defaults as previous. The configuration can be done via either a
config file or using CLI flags.

Closes hashicorp#3988
jrasell added a commit to jrasell/nomad that referenced this issue Mar 19, 2018
@jrasell
Allow Nomads Consul health checks to be configurable.
2439310 
This change allows the client HTTP and the server HTTP, Serf and
RPC health check names within Consul to be configurable with the
defaults as previous. The configuration can be done via either a
config file or using CLI flags.

Closes hashicorp#3988
@jrasell jrasell mentioned this issue Mar 19, 2018
Merged
@github-actions
Copy link

github-actions bot commented Dec 1, 2022

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
theme/consul theme/discovery type/enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@schmichael @jrasell