Allow Nomads Consul health check names to be configurable. #4003
Conversation
This change allows the client HTTP and the server HTTP, Serf and RPC health check names within Consul to be configurable with the defaults as previous. The configuration can be done via either a config file or using CLI flags. Closes hashicorp#3988
jrasell
changed the title
command/agent/command.go
Outdated
| @@ -120,8 +120,12 @@ func (c *Command) readConfig() *Config { | |||
| return nil | |||
| }), "consul-client-auto-join", "") | |||
| flags.StringVar(&cmdConfig.Consul.ClientServiceName, "consul-client-service-name", "", "") | |||
| flags.StringVar(&cmdConfig.Consul.ClientHTTPHealthCheckName, "consul-client-http-health-check-name", "", "") | |||
There was a problem hiding this comment.
Should the command line and configuration parameters use check instead of health-check to save a little repetition?
I'm fine with it either way, but since we're stuck with it ~forever once released if you want to shorten it to check please do so now. :)
There was a problem hiding this comment.
@schmichael it had crossed my mind that the flags and vars where fairly long; I will push a change to remove the health- from health-check shortly.
|
Test failures look unrelated. Merging. Thanks again @jrasell ! |
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
This change allows the client HTTP and the server HTTP, Serf and
RPC health check names within Consul to be configurable with the
defaults as previous. The configuration can be done via either a
config file or using CLI flags.
Once this is merged in, I will raise a ticket for documenting these
config parameters on the Nomad website.
Closes #3988