Set hostname when migrating ephemeral disks over TLS #4648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not setting the host name led the Go HTTP client to expect a certificate
with a DNS-resolvable name. Since Nomad uses `${role}.${region}.nomad`
names ephemeral dir migrations were broken when TLS was enabled.
Added an e2e test to ensure this doesn't break again as it's very
difficult to test and the TLS configuration is very easy to get wrong.
preetapan
reviewed
Sep 6, 2018
| @@ -666,13 +666,17 @@ func (c *Client) setServersImpl(in []string, force bool) (int, error) { | |||
| addr, err := resolveServer(srv) | |||
| if err != nil { | |||
| c.logger.Printf("[DEBUG] client: ignoring server %s due to resolution error: %v", srv, err) | |||
| mu.Lock() | |||
preetapan
approved these changes
Sep 6, 2018
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not setting the host name led the Go HTTP client to expect a certificate with a DNS-resolvable name. Since Nomad uses
${role}.${region}.nomadnames ephemeral dir migrations were broken when TLS was enabled.Added an e2e test to ensure this doesn't break again as it's very difficult to test and the TLS configuration is very easy to get wrong. Added new certificates for the test as our existing certificates allow
localhost,127.0.0.1which means this bug isn't triggered as those are valid hostnames.Snuck a little commit in that fixes a race.